Fix colors on the proctor login page for dark mode. (Bootstrap alert aproach)#2974
Open
drgrice1 wants to merge 1 commit into
Open
Fix colors on the proctor login page for dark mode. (Bootstrap alert aproach)#2974drgrice1 wants to merge 1 commit into
drgrice1 wants to merge 1 commit into
Conversation
The colors for this were inline style. Colors cannot be inline anymore since the server cannot detect if the user will have the browser in dark mode or not. So this switches to using Bootstrap alerts instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The colors for this were inline style. Colors cannot be inline anymore since the server cannot detect if the user will have the browser in dark mode or not. So this switches to using Bootstrap alerts instead.
This is an alternate approach to #2967.
One minor problem with this approach is that in the
math4-yellowtheme the difference between analert-primaryand analert-warningis somewhat subtle. Here is a screenshot demonstrating the two together with this pull request:The first alert in that image is an
alert-warningand the second is analert-primary.