Use custom btn-ww-info in UI.#2971
Open
somiaj wants to merge 1 commit into
Open
Conversation
Since btn-info is used for PG feedback buttons, modifying this button changes the colors seen in the PG feedback button. This configures and uses a custom btn-ww-info class instead of btn-info to allow theming and to not change the color of the PG feedback buttons. Due to the two new variables $ww-info and $ww-info-text this will break the building of any custom theme. I have opted to do not put in default values for this so anyone who has created a custom theme will see the breakage and realize they need to update their _theme-colors.css override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
btn-infois used for PG feedback buttons, modifying this button changes the colors seen in the PG feedback button. This configures and uses a custombtn-ww-infoclass instead ofbtn-infoto allow theming and to not change the color of the PG feedback buttons.Due to the two new variables
$ww-infoand$ww-info-textthis will break the building of any custom theme. I have opted to do not put in default values for this so anyone who has created a custom theme will see the breakage and realize they need to update their_theme-colors.cssoverride.