Set new defaults for caches and stores#2702
Open
aduffeck wants to merge 2 commits intoopencloud-eu:mainfrom
Open
Set new defaults for caches and stores#2702aduffeck wants to merge 2 commits intoopencloud-eu:mainfrom
aduffeck wants to merge 2 commits intoopencloud-eu:mainfrom
Conversation
See opencloud-eu#2681 for more details.
rhafer
requested changes
May 7, 2026
| Nodes: []string{"127.0.0.1:9233"}, | ||
| Database: "storage-system", | ||
| TTL: 24 * 60 * time.Second, | ||
| TTL: 24 * 60 * 60 * time.Second, |
Member
There was a problem hiding this comment.
🤔 how about 24 * time.Hour? But anyway, this is an memory Store by default, did you really want to change the value.
Member
Author
There was a problem hiding this comment.
Changed to time.Hour. And yes, I think it also makes sense fix the 24m vs 24h bug for the memory stores and set the TTL values as discussed in the linked issue.
|
rhafer
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2681 for more details.
fixes #2681