Hash app lock secrets#149
Conversation
307affe to
87d5933
Compare
84251c8 to
68ea357
Compare
guruz
left a comment
There was a problem hiding this comment.
I don't know what the intention was on how secure this app lock was needed to be. Maybe it's already considered secure enough for the use case so we don't need to bloat it? CC @kulmann
And instead of rolling your own hash etc, why not use https://developer.android.com/privacy-and-security/keystore or whatever else is current in last years?
|
yeah, i see the point. my intention here was not to redesign app lock around keystore, but to remove the current plaintext storage/logging issue with a small migration-friendly change. keystore would be the next level if we want to protect an encryption/signing key or bind access to device/user auth. that feels like a broader app-lock design decision though, especially around ux, backup/restore, key invalidation, and what threat model we actually want. so from my side this pr is just a hardening step for the existing implementation. if we want to move app lock to a keystore-based design, i'd treat that as a separate follow-up rather than mixing it into this pr. |
What changed
Why
The app lock should not leave the PIN or pattern readable in preferences or logs. Existing users can still unlock once with the old value, then it gets upgraded.
Checks