Uploads: Make more resistent to network or OS issues#145
Open
Conversation
Contributor
|
i did a deeper pass and i think the direction is good, especially letting filerequestbody throw instead of silently sending an empty put. one thing i would fix before merging: the cache check can reuse a non-empty cache file that belongs to another upload with the same target path. that could upload the wrong bytes. i think the cache path should include the upload id, or we should only reuse the cache when we can prove it belongs to the same content uri. |
Both the OS killing workers or just general network issues can accumulate failures that at some point lead to 0 byte files. For #78
Contributor
Author
Nice, I updated the PR to have it inside the temporary filename. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the OS killing workers or just general network issues can accumulate failures that at some point lead to 0 byte files.
For #78
CC @zerox80