Skip to content

fix: update metatype tests for v5#96

Merged
ehennestad merged 1 commit intomainfrom
fix-metatype-related-test-failures
Apr 28, 2026
Merged

fix: update metatype tests for v5#96
ehennestad merged 1 commit intomainfrom
fix-metatype-related-test-failures

Conversation

@ehennestad
Copy link
Copy Markdown
Collaborator

@ehennestad ehennestad commented Apr 28, 2026

Summary

  • Update MetaTypeTest/testMetaType to exercise openMINDS v5 DatasetVersion properties and type mappings.
  • Replace the removed mustBeSpecifiedLength validator test with coverage for mustBeMinLength and mustBeMaxLength.
  • Simplify scalar property detection to use the current mustBeScalarOrEmpty validator.

Root Cause

The test still asserted v4 DatasetVersion properties such as author, while v5 uses contribution and mixed linked properties such as digitalIdentifier and usageCondition. The scalar-detection helper also still looked for the removed mustBeSpecifiedLength validator.

Validation

runtests('ommtest.internal.MetaTypeTest')
runtests('PropertyValidatorTest')

@ehennestad ehennestad marked this pull request as ready for review April 28, 2026 21:05
@ehennestad ehennestad merged commit 964692d into main Apr 28, 2026
1 of 3 checks passed
@ehennestad ehennestad deleted the fix-metatype-related-test-failures branch April 28, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant