fix(collector): use Telemetry API event time as metric timestamp#2288
Open
dmedovich wants to merge 1 commit into
Open
fix(collector): use Telemetry API event time as metric timestamp#2288dmedovich wants to merge 1 commit into
dmedovich wants to merge 1 commit into
Conversation
|
|
Author
Member
|
Thank you for working on this @dmedovich! I will take some time tomorrow to take a closer look at your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recordMetricson the receiver (lastEventTime).lastEventTimeas the data point timestamp influshMetricsLocked, falling back totime.Now()only when no event has been observed yet (in which caseAppendDataPointsexports nothing anyway).r.mu, which already protects bothrecordMetricsandflushMetricsLocked.This mirrors the behavior of the log pipeline and resolves the metric/log timestamp divergence described in the linked issue.
Testing
TestMetricTimestampMatchesEventTime, which records events with a fixed RFC3339 time, performs a delayed flush, and asserts every Sum/Histogram data point'sTimestamp()matches the event time rather than wall-clocktime.Now().go test ./...andgo vet ./...pass for the package.Fixes #2263