Allow configuring websocket connect options#74
Open
kevinskysunny wants to merge 1 commit intoopen-dingtalk:mainfrom
Open
Allow configuring websocket connect options#74kevinskysunny wants to merge 1 commit intoopen-dingtalk:mainfrom
kevinskysunny wants to merge 1 commit intoopen-dingtalk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
websocket_connect_optionsargument toDingTalkStreamClient.websockets.connect().Why
Some production environments need to tune WebSocket open and keepalive timeouts for DingTalk Stream connections. The current SDK hardcodes the default
websockets.connect()behavior, so callers cannot adjustopen_timeout,ping_interval,ping_timeout, proxy behavior, or other supported options without patching the SDK locally.Validation
python3 -m py_compile dingtalk_stream/stream.py.