Preserve server-supplied fields on OAuth2Error#6
Open
AlexNachbaur wants to merge 2 commits intocrossapp-resource-paramfrom
Open
Preserve server-supplied fields on OAuth2Error#6AlexNachbaur wants to merge 2 commits intocrossapp-resource-paramfrom
AlexNachbaur wants to merge 2 commits intocrossapp-resource-paramfrom
Conversation
OAuth2 error responses may include server-specific remediation hints (e.g., required_acr, max_age) alongside the standard error/ error_description/error_uri fields. These were previously discarded. Adds an additional_fields mapping to OAuth2Error that holds any non-standard keys from the error response, and introduces OAuth2Error.from_response() as the primary way to construct an error from a parsed response body. Existing call sites in request_protocols and client are migrated to use it.
Adds an Error Handling section to the README describing OAuth2Error's shape and the new additional_fields mapping for server-supplied remediation hints, and lists the new surface under Unreleased in the CHANGELOG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth2 error responses may include server-specific remediation hints (e.g., required_acr, max_age) alongside the standard error/ error_description/error_uri fields. These were previously discarded.
Adds an additional_fields mapping to OAuth2Error that holds any non-standard keys from the error response, and introduces OAuth2Error.from_response() as the primary way to construct an error from a parsed response body. Existing call sites in request_protocols and client are migrated to use it.