fix(config): preserve min-release-age after flattening#9285
Open
lawrence3699 wants to merge 1 commit intonpm:latestfrom
Open
fix(config): preserve min-release-age after flattening#9285lawrence3699 wants to merge 1 commit intonpm:latestfrom
lawrence3699 wants to merge 1 commit intonpm:latestfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9199.
min-release-agederives abeforedate while config is flattened, but the flatten hook also deleted the originalmin-release-agevalue from the loaded config data. After anything readconfig.flat,npm config get min-release-ageandnpm config ls --longreportednulleven when the user had configured a value.This keeps the configured
min-release-agevalue readable while still derivingflat.beforefor package resolution.Before this change:
After this change:
Validation:
npm test --ignore-scripts npm run lint --ignore-scripts --workspace @npmcli/config npm run postlint --ignore-scripts --workspace @npmcli/config git diff --check