lib: remove source map deadcode in type stripping#63738
Merged
nodejs-github-bot merged 1 commit intoJun 8, 2026
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
module
legendecas
added
dont-land-on-v22.x
marco-ippolito
approved these changes
Jun 3, 2026
joyeecheung
approved these changes
Jun 4, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
`processTypeScriptCode` does not produce source maps at all for type stripping. Given that the transform mode was removed, there is no need to keep the source map support around it. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
module-remove-sourcemap-dead-code
branch
from
da0e566 to
0e851e7
Compare
Member
Author
|
Rebased to resolve conflicts. |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
approved these changes
Jun 7, 2026
Collaborator
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1b4e0fd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processTypeScriptCodedoes not produce source maps at all for typestripping. Given that the transform mode was removed, there is no need
to keep the source map support around it.
Refs: #61803