module: enable existing machinery for deferred imports#63712
Open
MayaLekova wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
MayaLekova
changed the title
nodejs-github-bot
added
c++
MayaLekova
force-pushed
the
import-defer-01
branch
from
0968bc3 to
6bb2db9
Compare
joyeecheung
reviewed
Jun 2, 2026
joyeecheung
left a comment
joyeecheung
left a comment
Member
There was a problem hiding this comment.
I think the commit message needs to clarify that this only makes it work for static import, but not dynamic import yet?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63712 +/- ##
========================================
Coverage 90.34% 90.35%
========================================
Files 732 732
Lines 236580 236709 +129
Branches 44545 44585 +40
========================================
+ Hits 213748 213870 +122
- Misses 14536 14565 +29
+ Partials 8296 8274 -22
🚀 New features to boost your workflow:
|
MayaLekova
force-pushed
the
import-defer-01
branch
from
6bb2db9 to
5e52c9a
Compare
Contributor
Author
|
Thank you, I moved the test, but should I add more extensive test coverage, even for static imports? |
Member
|
I think a smoke test is enough. The rest should be covered by test262 in the upstream. Can you rewrap the commit message to 72 chars to make the linter happy? Also this needs adding a eslint plugin
|
marco-ippolito
approved these changes
Jun 5, 2026
MayaLekova
force-pushed
the
import-defer-01
branch
3 times, most recently
from
2915765 to
bd9968c
Compare
guybedford
reviewed
Jun 8, 2026
This commit enables deferred import for statically imported modules, by using the corresponding functionality in V8. It adds two tests: - smoke test exercising the basic syntax - test for deferred import of module with its own imports More test coverage should be added for mixing ESM and CJS modules, as well as TypeScript modules. Refs: https://github.com/tc39/proposal-defer-import-eval Signed-off-by: Maya Lekova <maya@igalia.com>
MayaLekova
force-pushed
the
import-defer-01
branch
from
bd9968c to
569d71c
Compare
guybedford
approved these changes
Jun 9, 2026
guybedford
left a comment
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Works perfectly thank you!
joyeecheung
approved these changes
Jun 9, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
joyeecheung
reviewed
Jun 9, 2026
|
|
||
| // Attempts to define a property on the deferred module. This should | ||
| // trigger its execution, similar to accessing the `foo` property. | ||
| assert.throws(() => Object.defineProperty(deferred, 'newProp', { value: 15 }), TypeError); |
Member
There was a problem hiding this comment.
Suggested change
| assert.throws(() => Object.defineProperty(deferred, 'newProp', { value: 15 }), TypeError); | |
| assert.throws(() => Object.getOwnPropertyDescriptor(deferred, 'newProp'), TypeError); |
Linter is complaining that it's read-only, I think using the getter does what we want too anyway.
|
|
||
| import '../common/index.mjs'; | ||
|
|
||
| import defer * as deferred from '../fixtures/es-modules/module-with-module-tree.mjs' |
Member
There was a problem hiding this comment.
Suggested change
| import defer * as deferred from '../fixtures/es-modules/module-with-module-tree.mjs' | |
| import defer * as deferred from '../fixtures/es-modules/module-with-module-tree.mjs' | |
| console.log(defer.bar); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables deferred module imports by using the corresponding functionality in V8. It also adds a single test, but more test coverage should be added.
Refs: https://github.com/tc39/proposal-defer-import-eval