test: remove usage of inherits#63178
Conversation
|
Could you please add the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63178 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.02%
==========================================
Files 713 713
Lines 224645 224699 +54
Branches 42448 42480 +32
==========================================
+ Hits 202288 202297 +9
- Misses 14167 14183 +16
- Partials 8190 8219 +29 🚀 New features to boost your workflow:
|
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
…into update-test
I ran |
| // Inherits from EE without a call to the | ||
| // parent constructor. |
There was a problem hiding this comment.
Looks like that PR removes this check, seems important
There was a problem hiding this comment.
wich check are you talking about ?
There was a problem hiding this comment.
See the comment I've highlighted: having an object that inherits from EE without a call to the EE constructor (relevant section of the spec is https://tc39.es/ecma262/#sec-runtime-semantics-classdefinitionevaluation)
Description
Remove useage of utils.intherits on test. this legacy api is still tested
test-util-inherits.js