quic: remove unused binding variable in session.cc#63177
Open
jasnell wants to merge 2 commits intonodejs:mainfrom
Open
quic: remove unused binding variable in session.cc#63177jasnell wants to merge 2 commits intonodejs:mainfrom
jasnell wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
added
the
quic
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63177 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.02%
==========================================
Files 713 713
Lines 224645 224645
Branches 42448 42454 +6
==========================================
- Hits 202288 202261 -27
- Misses 14167 14176 +9
- Partials 8190 8208 +18 🚀 New features to boost your workflow:
|
pimterry
approved these changes
May 8, 2026
pimterry
added
request-ci
addaleax
approved these changes
May 8, 2026
addaleax
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as duplicate.
This comment was marked as duplicate.
jasnell
added
commit-queue
Member
Author
|
CI had already been run on this and had already passed (#63177 (comment)). Going to ignore the second flaky failure run |
jasnell
removed
commit-queue-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a couple stray unused variables.
@nodejs/quic