crypto: validate inputEncoding in Cipher/Decipher update#62954
Open
maruthang wants to merge 1 commit intonodejs:mainfrom
Open
crypto: validate inputEncoding in Cipher/Decipher update#62954maruthang wants to merge 1 commit intonodejs:mainfrom
maruthang wants to merge 1 commit intonodejs:mainfrom
Conversation
Cipher.update(string, badEncoding, ...) and Decipher.update with the same shape silently produced incorrect output: the binding skipped the unrecognized encoding and fell back to a default, giving the user wrong ciphertext or plaintext with no signal. Sub-cases 1 and 2 from issue nodejs#45189 (bad output encoding to update/final) were addressed in PR nodejs#45990. This commit completes the fix for sub-case 3 (bad input encoding) per panva's comment deferring it to a follow-up PR for CITGM testing. When `data` is a string and `inputEncoding` is non-null but does not normalize to a known encoding, throw ERR_UNKNOWN_ENCODING. Buffer / TypedArray / DataView data paths are unaffected (the binding ignores `inputEncoding` for non-string data anyway). Fixes: nodejs#45189 Refs: nodejs#45990 Signed-off-by: Maruthan G <maruthang4@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62954 +/- ##
==========================================
- Coverage 89.66% 89.60% -0.06%
==========================================
Files 706 704 -2
Lines 219391 218310 -1081
Branches 42068 41915 -153
==========================================
- Hits 196712 195616 -1096
- Misses 14578 14674 +96
+ Partials 8101 8020 -81
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cipher.update(string, badEncoding, ...) and Decipher.update with
the same shape silently produced incorrect output: the binding
skipped the unrecognized encoding and fell back to a default,
giving the user wrong ciphertext or plaintext with no signal.
Sub-cases 1 and 2 from issue #45189 (bad output encoding to
update/final) were addressed in PR #45990. This commit completes
the fix for sub-case 3 (bad input encoding) per panva's comment
deferring it to a follow-up PR for CITGM testing. When
dataisa string and
inputEncodingis non-null but does not normalizeto a known encoding, throw ERR_UNKNOWN_ENCODING. Buffer /
TypedArray / DataView data paths are unaffected (the binding
ignores
inputEncodingfor non-string data anyway).Fixes: #45189
Refs: #45990
Note: I was unable to run the test suite locally (no built
out/Release/nodeon this Windows host). Both touched files lint clean and passnode --check; the new test was confirmed to fail against the unpatched system Node v20 (so it actually exercises the bug). Looking forward to CI verification.