Skip to content

Downgrade the download-artifact version to match the upload-artifact version#324

Closed
mjohanse-emr wants to merge 1 commit into
mainfrom
users/mjohanse/pin_download_artifact_version
Closed

Downgrade the download-artifact version to match the upload-artifact version#324
mjohanse-emr wants to merge 1 commit into
mainfrom
users/mjohanse/pin_download_artifact_version

Conversation

@mjohanse-emr
Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

All PRs in this repo are failing. Copilot tells me it's likely because the download-artifact and upload-artifact major versions are different. This PR downgrades the download-artifact version to v7 to try and get the workflows passing again.

Why should this Pull Request be merged?

To unblock PRs in this repo.

What testing has been done?

PR workflow

…version

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

  119 files  ±0    119 suites  ±0   3m 26s ⏱️ -4s
  251 tests ±0    249 ✅ ±0   2 💤 ±0  0 ❌ ±0 
2 380 runs  ±0  2 350 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit b3b5334. ± Comparison against base commit 31ff0cc.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mismatched upload-artifact@v7 vs. download-artifact@v8 was a problem, it would break most of our other repos.

Example:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think I fell for a copilot hallucination.

@mjohanse-emr
Copy link
Copy Markdown
Collaborator Author

This version "mismatch" isn't really a problem. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants