fix(plyr): add l10n to components#3194
Open
szaimen wants to merge 2 commits into
Open
Conversation
Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
added
bug
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
2 tasks
szaimen
added
3. to review
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Contributor
Author
|
CI failure unrelated afaics |
Contributor
Author
|
/backport to stable32 |
artonge
reviewed
Jun 9, 2026
| * | ||
| * @param t the Nextcloud translation function (`this.t` in components) | ||
| */ | ||
| export function getPlyrTranslations(t: TranslateFn): Record<string, string> { |
Contributor
There was a problem hiding this comment.
I think you could simply import import { translate as t } from '@nextcloud/l10n' in this file and use it instead of passing it as an argument. Then this would be a static object instead of a function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)