fix(core): keep app menu settings icon legible on light backgrounds#61109
Merged
Conversation
pringelmann
requested review from
nfebe and
susnux
and removed request for
a team
pringelmann
added
bug
design
Contributor
Author
|
/backport to stable34 |
kra-mo
approved these changes
Jun 9, 2026
sorbaugh
approved these changes
Jun 9, 2026
susnux
requested changes
Jun 9, 2026
pringelmann
force-pushed
the
fix/waffle-current-app-icon-light-bg
branch
from
0095215 to
5233999
Compare
susnux
approved these changes
Jun 9, 2026
Contributor
Author
|
/compile amend |
pringelmann
force-pushed
the
fix/waffle-current-app-icon-light-bg
branch
from
5233999 to
81b6f84
Compare
jancborchardt
approved these changes
Jun 10, 2026
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
fix/waffle-current-app-icon-light-bg
branch
from
81b6f84 to
e38a873
Compare
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/waffle-current-app-icon-light-bg
branch
from
e38a873 to
4ea6917
Compare
Contributor
Author
|
@sorbaugh would you please force merge this one? |
github-project-automation
Bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current-app settings icon in the app menu header was an
<img>forced white with a CSS filter, so on a light header it stayed white. It now renders as an inline cog icon (the same approach as the waffle button), inheriting the header text color so it stays legible on both light and dark headers.I also changed the icon to a different cog variant. This one looks better imo :)
Screenshots
Checklist
3. to review, feature component)stable32)