fix(file-provider): invalidate lock tokens when file paths change. #10135
Draft
camilasan wants to merge 2 commits into
Draft
fix(file-provider): invalidate lock tokens when file paths change. #10135camilasan wants to merge 2 commits into
camilasan wants to merge 2 commits into
Conversation
WebDAV lock tokens are bound to the path they were issued for. When a parent folder moves, child lock tokens become stale and cause 412/423 upload failures. Clear tokens on rename propagation, server metadata sync, and upload lock errors. Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
Member
Author
|
/backport to stable-33.0 |
Member
Author
|
/backport to stable-4.0 |
This was referenced Jun 9, 2026
|
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10135.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
This PR is related to #10134, better to merge it afterwards.
Stale WebDAV lock token cleared on path change — when an editor locks a file the server issues a token bound to that file's path. If the parent folder is renamed the token becomes invalid.
The next save attempt sends a stale If: header. The server rejects it with 412/423, and the user cannot save — they must manually copy the file elsewhere.
Summary
The code now clears it whenever a rename is detected: during sync, in the DB rename functions, and on upload errors 412 and 423.
Steps to test it
✅ Save must succeed — no error dialog.
✅ The updated file must appear in the web UI with the new content.
✅ The second save must also succeed (confirms the token stays clear).
Enable verbose logging to confirm the log shows "Clearing stale lock token" followed by a successful upload.
Checklist
AI (if applicable)