Bugfix/noid/single app on linux using d bus#10088
Conversation
should help to build end-to-end integration tests with desktop files client and a Nextcloud server Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to detect if the installed binary was changed while the client is running, we used to synchronously try to run the binary to query its version this in addition with the need to prevent multiple running instances at the same time is creating a deadlock on start as an user, I do not expect my client to decide on its own to restart after my distribution updated the native package as a developer and administrator of a linux box, I expect the distribution tools to take care of restarting what should be restarted or at least notify about outdated running binaries this should not have been in scope of the client Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/noid/singleAppOnLinuxUsingDBus
branch
from
93ef976 to
ac77f8f
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10088.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
| : QApplication{argc, argv} | ||
| , _gui(nullptr) | ||
| #if defined KF6DBusAddons_FOUND && KF6DBusAddons_FOUND | ||
| , _dbusService{KDBusService::StartupOption::NoExitOnFailure | KDBusService::StartupOption::Unique} |
There was a problem hiding this comment.
we probably want to handle its activateRequested signal to deal with command line flags passed from a separate instance or e.g. display the main window
without it this would break the current experimental Linux VFS setup which some people use
There was a problem hiding this comment.
I did keep in parallel the older single app solution that should handle the communication between instances to ensure linux VFS and edit locally are still working
I will test again
2 participants
Resolves
#
Summary
TODO
Checklist
AI (if applicable)