feat(UI): Updated settings dialog UI

[Rello]

#9979

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[github-actions]

⚠️ modernize-use-override ⚠️
annotate this function with override or (rarely) final

Suggested change

	void initStyleOption(QStyleOptionToolButton *option) const
	void initStyleOption(QStyleOptionToolButton *option) const override

[kra-mo]

From the screenshots:

• Some of the settings seem to be translated, but some not. Was this already the case or did this break it?
• Where does the style of toggle switches come from? It's inconsistent with how it looks for virtual files. If it's custom, it would be good to make them look like how our switches look on the web anyway, or if not, get it to be consistent with virtual files.
• It would be good if the alignment of classic sync could be fixed as well (and also the gap between the title and description of virtual files, and the text clipping there).

The rest looks like improvements, a good next step.

[Rello]

@kra-mo

• Some of the settings seem to be translated, but some not. Was this already the case or did this break it?

as soon as its in master, the strings will be updated via transifex. the strings itself did not change, but their location.

• Where does the style of toggle switches come from? It's inconsistent with how it looks for virtual files. If it's custom, it would be good to make them look like how our switches look on the web anyway, or if not, get it to be consistent with virtual files.

it is custom and now also virtual files is using the same switch as the others. what you mean by web? these now smaller ones?

• It would be good if the alignment of classic sync could be fixed as well (and also the gap between the title and description of virtual files, and the text clipping there).

looking at it. its a completely different sub-window. thats why its a little annoying

[kra-mo]

these now smaller ones?

Yes

No Clang-Tidy warnings found so I assume my comments were addressed

[Rello]

@kra-mo
the switches were adjusted to match the Nextcloud UI. You think we can merge this now?

[kra-mo]

Yeah, looks better.

Could we also maybe make the sidebar full-height though? ;)

[Rello]

Yeah, looks better.

Could we also maybe make the sidebar full-height though? ;)

Hallo @kra-mo ,
i think it will not go through the header. this will be separate and might look off.
if ok for you I would merge this PR first and evaluate the other request in a smaller PR, because we are blocking several sections here...

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 532b8c4ce9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21d946657a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-10031.zip

Digest: sha256:b36e8437d8e62b89c2abbfa25807104cd86bde9a59f95a73213b91ef48ec62fa

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 Security Hotspot
5.8% Coverage on New Code (required ≥ 80%)
218 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE