Conversation
Because: - The pairing download screen served one static QR image to everyone, so mobile installs originating from a Send Tab flow could not be attributed separately from generic downloads. This commit: - Adds a reusable, domain-agnostic QRCode component (qrcode.react) that generates a QR from a value or renders a pre-rendered imageData URI, with an optional center logo (modules excavated behind it so it stays scannable) and a loading state. - Adds isSendTabEntrypoint (now a type guard) and buildPairingDownloadUrl: the generic mzl.la shortlink by default, and an Adjust deep-link (campaign=send-tab, creative=<entrypoint>) for Send Tab entrypoints so each is individually attributable. - Wires the component into the pairing download screen and removes the static qr_code_firefox_mobile.svg asset.
vbudhram
commented
Jun 9, 2026
| }: QRCodeProps) => { | ||
| const [delaying, setDelaying] = useState(!!loadingDelayMs); | ||
| useEffect(() => { | ||
| if (!loadingDelayMs) { |
Contributor
Author
There was a problem hiding this comment.
I added a delay here so that page feels a bit more "alive", otw the code shows almost instantly.
vbudhram
commented
Jun 9, 2026
| 'https://app.adjust.com/2uo1qc?campaign=%(campaign)s&creative=%(creative)s&adgroup=android&fallback=https://play.google.com/store/apps/details?id=org.mozilla.firefox', | ||
|
|
||
| // Generic pairing download QR target (Mozilla shortlink). | ||
| DOWNLOAD_LINK_PAIRING_QR_DEFAULT: 'https://mzl.la/3NDxAIS', |
Contributor
Author
There was a problem hiding this comment.
This is the url that is encoded in the old QR code svg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
QRCodecomponent (components/QRCode/index.tsx) usingqrcode.react: generates a QR from avalueor renders a pre-renderedimageDataURI, with an optional center logo (modules excavated behind it so it stays scannable), a loading state, and aloadingDelayMsreveal.buildPairingDownloadUrland turnsisSendTabEntrypointinto a type guard inlib/utilities.ts: the genericmzl.lashortlink by default, an Adjust deep-link (campaign=send-tab,creative=<entrypoint>) for Send Tab entrypoints so each is individually attributable. New constants inlib/constants.ts.pages/Pair/Index/index.tsx) and removes the staticqr_code_firefox_mobile.svgasset.qrcode.react@^4.2.0dependency; tests for the component, helpers, and per-entrypoint URL logic.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-13720
Checklist
Other information
How to test:
campaign=send-tab&creative=<entrypoint>(verify in the renderedvalue).https://mzl.la/3NDxAIS.