Put the new telemetry submission capability behind a feature#7358
Open
mhammond wants to merge 1 commit intomozilla:mainfrom
Open
Put the new telemetry submission capability behind a feature#7358mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond wants to merge 1 commit intomozilla:mainfrom
Conversation
This is slightly problematic on desktop. There's a good chance a callback interface would work, but that's a little problematic in other ways. This seems like a reasonable compromise while we work out a better option.
bendk
approved these changes
May 8, 2026
Contributor
bendk
left a comment
There was a problem hiding this comment.
This seems like a good workaround for now until we find a better solution for trait interfaces on desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is slightly problematic on desktop. There's a good chance a callback interface would work, but that's a little problematic in other ways (as that forces you to use a
Box<dyn T>instead of anArc<>, which is particularly problematic for tests. This seems like a reasonable compromise while we work out a better option.Pull Request checklist
[ci full]to the PR title.