Skip to content

Put the new telemetry submission capability behind a feature#7358

Open
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-klnkmuyxwnms
Open

Put the new telemetry submission capability behind a feature#7358
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-klnkmuyxwnms

Conversation

@mhammond
Copy link
Copy Markdown
Member

@mhammond mhammond commented May 8, 2026

This is slightly problematic on desktop. There's a good chance a callback interface would work, but that's a little problematic in other ways (as that forces you to use a Box<dyn T> instead of an Arc<>, which is particularly problematic for tests. This seems like a reasonable compromise while we work out a better option.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

This is slightly problematic on desktop. There's a good chance a callback
interface would work, but that's a little problematic in other ways.
This seems like a reasonable compromise while we work out a better option.
@mhammond mhammond requested review from bendk and leplatrem May 8, 2026 06:02
Copy link
Copy Markdown
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good workaround for now until we find a better solution for trait interfaces on desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants