Allow get_access_token to return tokens with multiple scopes#7357
Open
mhammond wants to merge 2 commits intomozilla:mainfrom
Open
Allow get_access_token to return tokens with multiple scopes#7357mhammond wants to merge 2 commits intomozilla:mainfrom
mhammond wants to merge 2 commits intomozilla:mainfrom
Conversation
c27ce0d to
9868242
Compare
bendk
approved these changes
May 8, 2026
Contributor
bendk
left a comment
There was a problem hiding this comment.
Looks good to me. I had a small suggestion, but no need for re-review.
| } | ||
| } | ||
| let mut requested_scopes: Vec<&str> = requested_set.iter().copied().collect(); | ||
| requested_scopes.sort_unstable(); |
Contributor
There was a problem hiding this comment.
Nit: Now that we have normalize_scopes, I think this could just be let requested_scopes: Vec<&str> = requested.split_ascii_whitespace().collect().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings mobile in line with desktop. Multiple scopes can be specified. These scopes are normalized and used as the cache key.
Split into 2 commits for ease of review:
Pull Request checklist
[ci full]to the PR title.