feat(sounds): add 14 mechanical sounds (@mshareef-git)#7764
feat(sounds): add 14 mechanical sounds (@mshareef-git)#7764mshareef-git wants to merge 8 commits intomonkeytypegame:masterfrom
Conversation
|
Any Updates? |
|
Hey, can you make sure all sounds are normalized to -10db? Also i would remove shadowgun, og oreo and cherrymx red. I also think with realistic sounds like mechanical switches, they would benefit greatly from less repetition by adding more sounds. (also sorry it took me this long) |
|
hey @Miodec sorry for the late reply i was a little busy, i have normalized all sounds to -10db, and removed those sound effects u mentioned. i am working on some other sound effects to but let me know if any changes are required. |
| <button data-config-value="14">fist fight</button> | ||
| <button data-config-value="15">rubber keys</button> | ||
| <button data-config-value="16">fart</button> | ||
| <button data-config-value="18">akko lavenders</button> |
There was a problem hiding this comment.
please change the ids to not have gaps
|
hi @mshareef-git , thank you for your contribution.
|
|
Hi @fehmer, thank you for the detailed feedback! I’ll be honest I’m still learning the ropes here, so I didn't quite catch everything you mentioned. I’m happy to apologize for the mess with the original wav files and the mp3s. I'll make sure to fix those and trim the folders down to 10 sounds each. Since you asked me to wait until your PR #7884 is merged: About how long do you think that might take? Also, should I wait until then to push the audio file fixes (WAV conversion and trimming), or should I do that part now? Thanks for your patience with me. |
|
Hi @mshareef-git , best would be for you to address the review comments and revert the changes in the sounds controller. I could either ping you when the PR got merged or add the changes needed for you. |
I really loved using sound effects in Monkeytype cause I don't have a mechanical keyboard, but there were limited options for sounds (just about 15 or so). That's why I added 14 new mechanical keyboard soundpacks. I previously contributed similar one called Wayvibes, so I wanted to bring that variety here.
below is the summary:
Added 14 new soundpacks (IDs click17 through click30) to frontend/static/sound/.
Included Sounds: Akko Lavenders, CherryMX (Black, Blue, Brown, Red in ABS/PBT), EG Oreo, Kailh Box White, Razer Green, Shadowgun, Tealios v2, and Trust GXT 865.
Standardized naming: Followed the existing clickXX_N.wav/mp3 format for all audio files to ensure consistency with the current codebase.
Code Updates:
Updated packages/schemas/src/configs.ts to whitelist new sound IDs.
Mapped new audio assets in frontend/src/ts/controllers/sound-controller.ts.
Added UI buttons in frontend/src/html/pages/settings.html and CLI aliases in frontend/src/ts/commandline/commandline-metadata.ts.
Checks
[ ] Adding quotes?
[ ] Adding a language?
[ ] Adding a theme?
[ ] Adding a layout?
[ ] Adding a font?
[x] Check if any open issues are related to this PR; if so, be sure to tag them below.
[x] Make sure the PR title follows the Conventional Commits standard.
[x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.