Skip to content

fix(mfdataplist): raise proper MFDataException on wrong col count#2766

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:fix/mfdataplist-dataframe-error-message
Jun 8, 2026
Merged

fix(mfdataplist): raise proper MFDataException on wrong col count#2766
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:fix/mfdataplist-dataframe-error-message

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

Fix a minor issue mentioned in #2758. When a dataframe passed to set_data() has the wrong column count, the intended error would not be raised, instead you'd get a KeyError.

@wpbonelli wpbonelli added this to the 3.10.1 milestone Jun 8, 2026
@wpbonelli wpbonelli added the bug label Jun 8, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (725128b).
⚠️ Report is 169 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2766      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +17.0%     
===========================================
  Files          644      677      +33     
  Lines       124135   132686    +8551     
===========================================
+ Hits         68947    96269   +27322     
+ Misses       55188    36417   -18771     
Files with missing lines Coverage Δ
flopy/mf6/data/mfdataplist.py 71.9% <ø> (-6.9%) ⬇️

... and 579 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review June 8, 2026 19:55
@wpbonelli wpbonelli merged commit c27af43 into modflowpy:develop Jun 8, 2026
19 checks passed
@wpbonelli wpbonelli deleted the fix/mfdataplist-dataframe-error-message branch June 8, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant