Skip to content

Enable netfx UI MCP clients #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KirillOsenkov wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

Enable netfx UI MCP clients #1639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/ModelContextProtocol.Core/Client/StdioClientTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,29 @@ public async Task<ITransport> ConnectAsync(CancellationToken cancellationToken =
lock (s_consoleEncodingLock)
{
Encoding originalInputEncoding = Console.InputEncoding;
bool encodingChanged = false;
try
{
Console.InputEncoding = StreamClientSessionTransport.NoBomUtf8Encoding;
try
{
Console.InputEncoding = StreamClientSessionTransport.NoBomUtf8Encoding;
encodingChanged = true;
}
catch
{
// Host has no usable console (e.g. WPF/WinForms on .NET Framework with no
// AllocConsole). The child inherits the current Console.InputEncoding;
// non-ASCII stdin may be misencoded, but the connect itself proceeds.
}

processStarted = process.Start();
}
finally
{
Console.InputEncoding = originalInputEncoding;
if (encodingChanged)
{
Console.InputEncoding = originalInputEncoding;
}
}
}
#endif
Expand Down