Agents: Implement scrollable container for welcome prompts#312357
Merged
mrleemurray merged 4 commits intomainfrom Apr 24, 2026
Merged
Agents: Implement scrollable container for welcome prompts#312357mrleemurray merged 4 commits intomainfrom
mrleemurray merged 4 commits intomainfrom
Conversation
…rsAICustomizationWelcomePage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AI Customization welcome page prompt launchers to render inside a DomScrollableElement wrapper so the welcome prompts area can scroll reliably and compute scroll dimensions correctly as the container resizes.
Changes:
- Wrapped the welcome prompt content container in
DomScrollableElementand added resize observation to re-scan scroll dimensions on host resize. - Updated the welcome prompt launcher CSS to introduce a dedicated scrollable wrapper element and adjust positioning/overflow so scrolling is handled by
DomScrollableElement.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationWelcomePromptLaunchers.css | Adds wrapper styling (.welcome-prompts-scrollable) and adjusts the content container layout to work with DomScrollableElement scrolling. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationWelcomePagePromptLaunchers.ts | Introduces DomScrollableElement usage, observes wrapper resize to rescan dimensions, and rescans after card rebuilds. |
roblourens
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a scrollable container for welcome prompts to enhance user experience. Improve scrollbar resize observation logic and update CSS for better layout and positioning. Adjustments ensure that the scroll dimensions are computed correctly, providing a smoother interaction with the content.