Optimize type variable scope map cloning with CoW#3573
Open
jakebailey wants to merge 2 commits intomainfrom
Open
Optimize type variable scope map cloning with CoW#3573jakebailey wants to merge 2 commits intomainfrom
jakebailey wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores a copy-on-write approach for NodeBuilderContext’s per-signature scope maps to reduce allocations when cloning scope state during type serialization.
Changes:
- Added
core.CloneOrMakeMaputility to clone an existing map or allocate an empty one when nil. - Updated
cloneNodeBuilderContextto share inherited maps and defer cloning until mutation is required. - Updated node builder mutation sites to clone-on-first-write using
core.CloneOrMakeMap.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/core/core.go | Adds CloneOrMakeMap helper to support clone-on-write map patterns. |
| internal/checker/nodebuilderscopes.go | Switches scope cloning from eager map cloning to CoW by resetting “created” flags while sharing maps. |
| internal/checker/nodebuilderimpl.go | Clones the shared maps on first mutation using core.CloneOrMakeMap instead of allocating fresh empty maps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the copy-on-write in the original Strada code, which saves the creation of new maps. On the testrunner test suite, this saves about 720k allocations.