docs: add container runtime scenario to E2E test documentation#675
Open
bfjelds wants to merge 6 commits into
Open
docs: add container runtime scenario to E2E test documentation#675bfjelds wants to merge 6 commits into
bfjelds wants to merge 6 commits into
Conversation
Add comprehensive coverage of the container runtime alongside the existing host runtime documentation. Key additions: - Intro section explaining host vs container runtime differences - Container COSI image types table (container-testimage, container-verity, container-usrverity) alongside host images - Build step for Trident Docker container image (docker-build + tarball) - Container-specific COSI image build commands - Container installer ISO download instructions - VM memory requirements for container (11+ GiB for Docker overhead) - Container netlaunch target (run-netlaunch-container-images) - Host Configuration additionalFiles entry for container tarball - Pytest -R container flag usage - Storm-trident ab-update with container runtime type - Pipeline scheduling showing container entries in target-configurations.yaml - SELinux check note (host-only) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bfjelds
commented
Jun 8, 2026
bfjelds
commented
Jun 8, 2026
- Change 'host OS' to 'servicing OS' for accuracy - Replace pipeline download with local build for container installer ISO (testimages.py build trident-container-installer) — no pipeline access needed - Consolidate QEMU VM creation to one command with a note about --mem 12 being required only for container runtime Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The pipeline storm-trident helper prepare-images renames all COSI images to the same output filenames regardless of runtime. Align the manual build instructions to match so Host Configuration image URLs work unchanged for both runtimes. Also: - Add explicit SSH public key injection step (configs ship with empty sshPublicKeys list, which blocks pytest SSH access) - Restructure Host Configuration section with subheadings for clarity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the E2E test documentation to cover running scenarios where Trident executes inside a Docker container, alongside the existing host-runtime workflow, aligning the doc with pipeline/runtime distinctions used by storm-trident and netlaunch.
Changes:
- Adds an introduction explaining host vs container runtime artifacts and behavioral differences.
- Documents container-specific COSI image types and build steps (including container tarball handling and netlaunch target).
- Updates run instructions/examples for pytest and A/B update flows to include container runtime flags and scheduling examples.
Update container runtime section to recommend the Make target (download from pipeline) as the primary method, with testimages.py as a local-build alternative. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit dfe3031.
The Makefile target uses zstd compression (docker save | zstd), not gzip. Update the docs to match the actual build behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive coverage of the container runtime alongside the existing host runtime documentation in E2E-Tests.md.
Changes
un-netlaunch-container-images)
Derived from the actual pipeline definitions (\�2e-template.yml,
etlaunch-testing.yml, \download-test-images.yml, \ rident-prep.yml, \ rident-container.yml) and Makefile targets.