Skip to content

fix: use IsPrimary() for touch pointer isPrimary instead of hardcoded id #16099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmacmaster wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix: use IsPrimary() for touch pointer isPrimary instead of hardcoded id #16099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2801b6f
Create react-native-windows-4ad3ddaf-1358-4ff0-9971-38a7db68266c.json
gmacmaster May 8, 2026
2813cac
fix: use IsPrimary() for touch pointer isPrimary instead of hardcoded…
gmacmaster May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-4ad3ddaf-1358-4ff0-9971-38a7db68266c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: use IsPrimary() for touch pointer isPrimary instead of hardcoded pointer ID check",
"packageName": "react-native-windows",
"email": "gordomacmaster@gmail.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/CompositionEventHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,7 +1366,7 @@ void CompositionEventHandler::onPointerPressed(

UpdateActiveTouch(activeTouch, ptScaled, ptLocal);

activeTouch.isPrimary = pointerId == 1;
activeTouch.isPrimary = pointerPoint.Properties().IsPrimary();
// Map the Windows pointer ID to a small identifier (0–19) safe for use as a JS array index.
// Windows touch IDs can be arbitrarily large (e.g. 2233), which causes React Native to warn
// and corrupts touch state, leaving Pressables stuck after a scroll.
Expand Down
Loading