fix(page): restore test timeout after page.pause() in headless mode#40401
Open
abhi41289 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix(page): restore test timeout after page.pause() in headless mode#40401abhi41289 wants to merge 2 commits intomicrosoft:mainfrom
abhi41289 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
When the same @tag appears in both a describe title and a test title (or in nested describe blocks), test.tags returned it multiple times. Wrap the result in Set to deduplicate. Fixes microsoft#40368
page.pause() called onWillPause() which incremented the ignore-timeouts counter, but never decremented it. In headed/inspector mode this was intentional (timeouts stay off for the debug session). In headless mode the pause resolves immediately with no inspector, leaving the counter permanently elevated and disabling the test timeout for the rest of the test run. Add onDidResume() to ClientInstrumentation, called after channel.pause() resolves, so the counter is balanced regardless of mode. Fixes microsoft#38754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.pause()callsonWillPause()which increments the ignore-timeouts counter, but never decremented itchannel.pause()resolves immediately (no inspector to handle it), leaving the counter permanently elevated and disabling the test timeout for the rest of the testonDidResume()toClientInstrumentation, called afterchannel.pause()resolves, so the counter is always balancedFixes #38754