fix(reporter): deduplicate tags when same tag appears in multiple scopes#40400
Open
abhi41289 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(reporter): deduplicate tags when same tag appears in multiple scopes#40400abhi41289 wants to merge 1 commit intomicrosoft:mainfrom
abhi41289 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When the same @tag appears in both a describe title and a test title (or in nested describe blocks), test.tags returned it multiple times. Wrap the result in Set to deduplicate. Fixes microsoft#40368
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.tagsreturned duplicate entries when the same@tagappeared in both adescribetitle and atesttitle (or across nesteddescribeblocks)get tags()in[...new Set(...)]inpackages/playwright/src/common/test.tstests/playwright-test/test-tag.spec.tscovering describe+test title dedup and explicit{ tag }dedupFixes #40368