update hcs.Start to use HCS V1 API#2729
Merged
rawahars merged 1 commit intomicrosoft:mainfrom May 9, 2026
Merged
Conversation
Presently, the implementation of Start method used computecore i.e. HCS V2 for starting the compute system. However, the same compute system was created using HCS V1 and therefore, due to an incompatibility within HCS between V1 and V2 APIs, this was failing. Therefore, as a stop gap, we have reverted the Start method to use the HCS V1 API. During our full scale migration to V2 APIs, this will be taken care of properly. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
jterry75
approved these changes
May 8, 2026
AdityaMittal1306
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Presently, the implementation of Start method used computecore i.e. HCS V2 for starting the compute system. However, the same compute system was created using HCS V1 and therefore, due to an incompatibility within HCS between V1 and V2 APIs, this was failing.
Therefore, as a stop gap, we have reverted the Start method to use the HCS V1 API. During our full scale migration to V2 APIs, this will be taken care of properly.
Start implementation in old code using HCS V1-
hcsshim/internal/hcs/system.go
Line 195 in 2e7b58a