Draft: add manual VHDX compaction command for stopped WSL distros#40481
Open
Guayamose wants to merge 5 commits intomicrosoft:masterfrom
Open
Draft: add manual VHDX compaction command for stopped WSL distros#40481Guayamose wants to merge 5 commits intomicrosoft:masterfrom
Guayamose wants to merge 5 commits intomicrosoft:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a manual-only VHDX compaction path for stopped WSL 2 distributions, exposed via wsl --manage <Distro> --compact, with service plumbing and a Virtual Disk API helper.
Changes:
- Introduces
--compactinwsl.exe --manage, routed throughSvcCommto the service. - Implements a service-side
CompactDistributionpath that rejects non-WSL2 and running/in-use distros and invokesCompactVirtualDisk. - Updates help/localization text and adds a WSL2 unit test covering the compact flow.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/UnitTests.cpp | Adds help text expectation and a new WSL2 test for --manage --compact. |
| src/windows/service/inc/wslservice.idl | Extends ILxssUserSession with CompactDistribution RPC method. |
| src/windows/service/exe/LxssUserSession.h | Declares CompactDistribution on the COM class + impl. |
| src/windows/service/exe/LxssUserSession.cpp | Implements CompactDistribution validation and VHD compaction call path. |
| src/windows/inc/wsl.h | Adds --compact manage option constant. |
| src/windows/common/WslCoreFilesystem.h | Declares CompactVhd helper. |
| src/windows/common/WslCoreFilesystem.cpp | Implements CompactVhd via OpenVirtualDisk + CompactVirtualDisk. |
| src/windows/common/WslClient.cpp | Adds CLI parsing/dispatch for --manage --compact. |
| src/windows/common/svccomm.hpp | Adds SvcComm::CompactDistribution declaration. |
| src/windows/common/svccomm.cpp | Wires SvcComm::CompactDistribution to ILxssUserSession. |
| localization/strings/en-US/Resources.resw | Adds --compact help text + locked token list update. |
| localization/strings/es-ES/Resources.resw | Adds Spanish --compact help text + locked token list update. |
This was referenced May 10, 2026
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Related to #40243 and #4699.
This is an exploratory draft PR for a manual-only VHDX compaction path.
It adds a new manual command:
wsl --manage <Distro> --compactThe command compacts the VHDX backing file for a stopped WSL 2 distro using the Windows Virtual Disk API.
This PR intentionally does not add automatic compaction yet.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Scope
Included:
OpenVirtualDiskandCompactVirtualDisk.wsl --manage <Distro> --compact.ERROR_SHARING_VIOLATION.Not included:
.wslconfigpolicy.Motivation
The broader issue in #4699 is that WSL 2 distro VHDX files can grow significantly and not release space back to the host automatically.
In #40243 I proposed a safer path around shutdown/offline compaction. Before attempting any automatic policy, this PR adds a smaller manual command first, so the Virtual Disk API integration and safety model can be reviewed independently.
Validation
Built successfully on Windows:
cmake .cmake --build . --config Debug --target wsl wslservice wsltests -- /mcmake --build . --config Debug --target msixinstallerpackage -- /mTested:
UnitTests::UnitTests::Compactpassed.Wsl/Service/WSL_E_DISTRO_NOT_STOPPED.wsl --manage Ubuntu --compact --resize 10GBdid not compact and failed argument validation/help as expected.Manual validation result:
wsl --manage Ubuntu --compactLa operación se completó correctamente.0-2,097,152 byteswsl -d Ubuntu -- echo okok0Running distro validation:
wsl --manage Ubuntu --compactWsl/Service/WSL_E_DISTRO_NOT_STOPPED-10Notes
This is opened as a draft because the intended first step is design and maintainer feedback on the manual command surface and service/helper integration.
Open questions:
wsl --manage <Distro> --compactthe right CLI surface?Future work, if this direction is acceptable: