Skip to content

Fix ListImages test flaky Before/Since filter ordering #40468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benhillis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ListImages test flaky Before/Since filter ordering #40468

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1512313
Fix ListImages test flaky Before/Since filter ordering
May 8, 2026
d39f554
format
May 8, 2026
5457b57
Address PR feedback: assert Created timestamps are populated and dist…
May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 38 additions & 13 deletions test/windows/WSLCTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,69 +898,94 @@ class WSLCTests

LogInfo("Test: Before/Since filters");
{
// Get all images to find their IDs
// Get all images to find their IDs and creation times
wil::unique_cotaskmem_array_ptr<WSLCImageInformation> allImages;
VERIFY_SUCCEEDED(m_defaultSession->ListImages(nullptr, allImages.addressof(), allImages.size_address<ULONG>()));

std::string debianId, pythonId;
LONGLONG debianCreated = 0, pythonCreated = 0;
for (const auto& image : allImages)
{
std::string imageName = image.Image;
if (imageName == "debian:latest")
{
debianId = image.Hash;
debianCreated = image.Created;
}
else if (imageName == "python:3.12-alpine")
{
pythonId = image.Hash;
pythonCreated = image.Created;
}
}

VERIFY_IS_FALSE(debianId.empty());
VERIFY_IS_FALSE(pythonId.empty());

// Test 'since' filter - images created after debian
// Both Created timestamps must be populated and distinct so that the since/before
// boundaries are unambiguous. Equal timestamps would make Docker's filter behavior
// ambiguous and could reintroduce flakiness.
VERIFY_IS_GREATER_THAN(debianCreated, 0LL);
VERIFY_IS_GREATER_THAN(pythonCreated, 0LL);
VERIFY_ARE_NOT_EQUAL(debianCreated, pythonCreated);

// Determine which image is older/newer based on actual creation timestamps.
// Image creation times come from the registry and can change independently.
const bool debianIsOlder = debianCreated < pythonCreated;
const auto& olderId = debianIsOlder ? debianId : pythonId;
const auto& newerId = debianIsOlder ? pythonId : debianId;
const auto* olderName = debianIsOlder ? "debian:latest" : "python:3.12-alpine";
const auto* newerName = debianIsOlder ? "python:3.12-alpine" : "debian:latest";

LogInfo(
"Older image: %hs (Created: %lld), Newer image: %hs (Created: %lld)",
olderName,
debianIsOlder ? debianCreated : pythonCreated,
newerName,
debianIsOlder ? pythonCreated : debianCreated);

Comment thread
benhillis marked this conversation as resolved.
// Test 'since' filter - images created after the older image
{
WSLCListImageOptions options{};
options.Flags = WSLCListImagesFlagsNone;
options.Since = debianId.c_str();
options.Since = olderId.c_str();

wil::unique_cotaskmem_array_ptr<WSLCImageInformation> images;
VERIFY_SUCCEEDED(m_defaultSession->ListImages(&options, images.addressof(), images.size_address<ULONG>()));
VERIFY_IS_TRUE(images.size() > 0);

bool foundPython = false;
bool foundNewer = false;
for (const auto& image : images)
{
LogInfo("Image: %hs, Hash: %hs, Created: %lld", image.Image, image.Hash, image.Created);
if (std::string{image.Image} == "python:3.12-alpine")
if (std::string{image.Image} == newerName)
Comment on lines +957 to +961
{
foundPython = true;
foundNewer = true;
}
}

VERIFY_IS_TRUE(foundPython);
VERIFY_IS_TRUE(foundNewer);
}

// Test 'before' filter - images created before python
// Test 'before' filter - images created before the newer image
{
WSLCListImageOptions options{};
options.Flags = WSLCListImagesFlagsNone;
options.Before = pythonId.c_str();
options.Before = newerId.c_str();
wil::unique_cotaskmem_array_ptr<WSLCImageInformation> images;
VERIFY_SUCCEEDED(m_defaultSession->ListImages(&options, images.addressof(), images.size_address<ULONG>()));
VERIFY_IS_TRUE(images.size() > 0);

bool foundDebian = false;
bool foundOlder = false;
for (const auto& image : images)
{
if (std::string{image.Image} == "debian:latest")
if (std::string{image.Image} == olderName)
{
Comment on lines +979 to 983
foundDebian = true;
foundOlder = true;
}
}

VERIFY_IS_TRUE(foundDebian);
VERIFY_IS_TRUE(foundOlder);
Comment thread
benhillis marked this conversation as resolved.
}
}

Expand Down
Loading