Conversation
This reverts commit b6914ac.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the Azure Pipelines packaging workflow to add Windows ARM64 coverage across SDK test stages and ensure the Core build/test flow runs appropriately on win-arm64 agents.
Changes:
- Add win-arm64 test jobs for C#, JS, Python, and Rust (standard + WinML) in the packaging pipeline.
- Run Foundry Local Core tests for the win-arm64 Core build flavor (while continuing to skip osx-arm64 Core tests due to CI flakiness).
- Add a NuGet global-packages cache clear step to the C# test template and install git-lfs on AcesShared macOS agents before LFS checkouts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .pipelines/templates/test-cs-steps.yml | Adds a NuGet global-packages cache clear step before restoring/building C# tests. |
| .pipelines/templates/build-core-steps.yml | Expands the Core test gating to include win-arm64 in the non-WinML build flow. |
| .pipelines/foundry-local-packaging.yml | Adds win-arm64 test jobs across SDK stages, updates win-arm64 pool, and installs git-lfs on macOS jobs before LFS checkouts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $cacheDir = Join-Path $env:USERPROFILE '.nuget' 'packages' | ||
| if (Test-Path $cacheDir) { | ||
| Write-Host "Clearing NuGet packages cache: $cacheDir" | ||
| Remove-Item -Recurse -Force "$cacheDir\*" | ||
| } else { | ||
| Write-Host "NuGet packages cache not found at $cacheDir, skipping." | ||
| } |
There was a problem hiding this comment.
This cache-clearing step is not safe on the Linux/macOS C# test jobs that also use this template: $env:USERPROFILE is typically unset under pwsh on non-Windows agents (causing Join-Path to throw), and "$cacheDir\*" is Windows-path specific. Consider either gating this step to Windows only (e.g., $IsWindows / condition: eq(variables['Agent.OS'], 'Windows_NT')) or using a cross-platform command like dotnet nuget locals global-packages --clear (or clearing $env:NUGET_PACKAGES when set).
| $cacheDir = Join-Path $env:USERPROFILE '.nuget' 'packages' | |
| if (Test-Path $cacheDir) { | |
| Write-Host "Clearing NuGet packages cache: $cacheDir" | |
| Remove-Item -Recurse -Force "$cacheDir\*" | |
| } else { | |
| Write-Host "NuGet packages cache not found at $cacheDir, skipping." | |
| } | |
| Write-Host "Clearing NuGet global-packages cache" | |
| dotnet nuget locals global-packages --clear | |
| if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } |
| # AcesShared macOS agents don't have git-lfs pre-installed | ||
| - script: brew install git-lfs && git lfs install | ||
| displayName: 'Install Git LFS' | ||
| - checkout: neutron-server | ||
| clean: true | ||
| - checkout: test-data-shared | ||
| lfs: true |
There was a problem hiding this comment.
In flc_osx_arm64, test-data-shared is checked out with LFS (and git-lfs is installed) even though build-core-steps.yml doesn’t reference test-data-shared, and Core tests are currently skipped for osx-arm64 (per the build-core template condition). If the checkout is only needed for tests, consider removing the brew install git-lfs + checkout: test-data-shared here to reduce job time and bandwidth until osx-arm64 tests are re-enabled.
| # AcesShared macOS agents don't have git-lfs pre-installed | |
| - script: brew install git-lfs && git lfs install | |
| displayName: 'Install Git LFS' | |
| - checkout: neutron-server | |
| clean: true | |
| - checkout: test-data-shared | |
| lfs: true | |
| - checkout: neutron-server | |
| clean: true |
This reverts commit 96d14a2.
No description provided.