[Bugfix][SM6.10] Allow LinAlgMatrix type in the validator#8441
Open
V-FEXrt wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Haha ope I felt that coming :) Poking at figuring that out |
Collaborator
Author
|
@llvm-beanz done! |
tex3d
reviewed
May 11, 2026
| return true; | ||
| // Allow LinAlgMatrix type. | ||
| if (dxilutil::IsHLSLLinAlgMatrixType(ST)) | ||
| return true; |
Contributor
There was a problem hiding this comment.
Ok for now, but as a follow up, I think we'll have to be careful where we allow this type in DXIL. For instance, we probably shouldn't allow it in user function parameters or return types. We should probably file an issue, since this change alone might lead us to be overly-permissive of the type.
Collaborator
Author
There was a problem hiding this comment.
I think there are a couple cases were it is in the return type of final DXIL but I'll go ahead and file an issues to tighten this up
Collaborator
Author
There was a problem hiding this comment.
tex3d
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8433
The validator was rejecting
%dx.types.LinAlgMatrix***types causing debug build to be rejected. This PR notes that type as an allowed type