Skip to content

Bug 620556: [Subcontracting] Align Subcontracting app with changes to the "Description 2" on various tables#7831

Open
ChethanT wants to merge 6 commits intomainfrom
bugs/Subcontracting/620556-AlighWithDesc2
Open

Bug 620556: [Subcontracting] Align Subcontracting app with changes to the "Description 2" on various tables#7831
ChethanT wants to merge 6 commits intomainfrom
bugs/Subcontracting/620556-AlighWithDesc2

Conversation

@ChethanT
Copy link
Copy Markdown
Contributor

@ChethanT ChethanT commented Apr 23, 2026

Summary

  • SubcPurchaseOrderCreator: copy Description 2 from ProdOrderComponent (not Item) to PurchaseLine; copy from ProdOrderRoutingLine (not blank) to RequisitionLine
  • SubcTempDataInitializer: propagate Description 2 from RoutingLine → temp ProdOrderRoutingLine and from ProductionBOMLine → temp ProdOrderComponent
  • SubcCreateProdOrdOpt: include Description 2 in SetLoadFields; propagate it to PurchaseLine, ProductionBOMHeader, RoutingHeader, ProdOrderComponent, and ProdOrderRoutingLine when committing wizard data
  • Pages: surface Description 2 (hidden) on SubcProdOrderComponents, SubcPurchProvisionWizard, and all four wizard list part pages

Root cause

Bug 617366 added the Description 2 field to manufacturing tables in the base app. The Subcontracting app was not updated to propagate that field through its wizard pipeline or purchase order creation flow, causing the field to be lost or blanked.

Fixes AB#620556

🤖 Generated with Claude Code

… the "Description 2" on various tables (AB#620556)

Align the Subcontracting app with the "Description 2" field that was
added to manufacturing tables in the base app. The field was not being
propagated through the Subcontracting wizard pipeline or purchase order
creation flow.

- SubcTempDataInitializer: copy Description 2 from RoutingLine into the
  temp ProdOrderRoutingLine, and from ProductionBOMLine into the temp
  ProdOrderComponent
- SubcCreateProdOrdOpt: include Description 2 in SetLoadFields for routing
  lines; propagate it to PurchaseLine, ProductionBOMHeader, RoutingHeader,
  ProdOrderComponent, and ProdOrderRoutingLine when committing wizard data
- SubcPurchaseOrderCreator: copy Description 2 from ProdOrderComponent
  (instead of Item) to PurchaseLine; copy Description 2 from
  ProdOrderRoutingLine (instead of blank) to RequisitionLine
- SubcProdOrderComponents page: surface Description 2 field (hidden)
- SubcPurchProvisionWizard page: surface Description 2 field (hidden)
- Wizard list part pages (SubcTempBOMLines, SubcTempRoutingLines,
  SubcTempProdOrderComp, SubcTempProdOrdRtngLines): add Description 2
  field with ToolTip

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 23, 2026 09:08
@ChethanT ChethanT requested a review from a team as a code owner April 23, 2026 09:08
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Apr 23, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the Subcontracting app’s wizard and purchase-order creation flows with the base manufacturing tables’ new Description 2 field so that the value is preserved instead of being lost/blanked.

Changes:

  • Propagates Description 2 through temporary wizard tables and into created production/BOM/routing records.
  • Copies Description 2 into created Purchase Line / Requisition Line records from the correct manufacturing sources.
  • Adds hidden Description 2 fields to relevant wizard/list pages to surface the field for data-binding.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Pages/SubcTempRoutingLines.Page.al Adds hidden Description 2 control to temp Routing Lines list part.
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Pages/SubcTempProdOrderComp.Page.al Adds hidden Description 2 control to temp Prod. Order Components list part.
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Pages/SubcTempProdOrdRtngLines.Page.al Adds hidden Description 2 control to temp Prod. Order Routing Lines list part.
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Pages/SubcTempBOMLines.Page.al Adds hidden Description 2 control to temp Production BOM Lines list part.
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Pages/SubcPurchProvisionWizard.Page.al Adds hidden, read-only Description 2 field on the wizard’s General section.
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Codeunits/SubcTempDataInitializer.Codeunit.al Copies Description 2 from Routing/BOM lines into the temporary global prod. order tables.
src/Apps/W1/Subcontracting/App/src/Process/Prod Order Creation Wizard/Codeunits/SubcCreateProdOrdOpt.Codeunit.al Loads and commits Description 2 into Purchase Line, headers, and prod. order component/routing lines.
src/Apps/W1/Subcontracting/App/src/Process/Pages/SubcProdOrderComponents.Page.al Adds hidden Description 2 field to the subcontracting components list page.
src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcPurchaseOrderCreator.Codeunit.al Copies Description 2 from Prod. Order Component / Routing Line into Purchase Line / Requisition Line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL Documentation Audit

Documentation gaps were detected in the following apps:

  • Subcontracting: 0% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

…OrderCreator

Agent-Logs-Url: https://github.com/microsoft/BCApps/sessions/18b80cea-032f-4e07-ab1c-21eee8ba5f5f

Co-authored-by: ChethanT <41570277+ChethanT@users.noreply.github.com>
PredragMaricic
PredragMaricic previously approved these changes Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants