fix: set Recurring Billing before Pay-to Vendor validation in CreatePurchaseHeaderFromContract

[jeffreybulanadi]

Fixes #4302

Problem

In CreateBillingDocuments.Codeunit.al, CreatePurchaseHeaderFromContract calls Validate("Pay-to Vendor No.", ...) before setting PurchaseHeader."Recurring Billing" := true. Localization extensions (such as the Hungarian localization) add a validation trigger on the "Pay-to Vendor No." field that checks whether the document is a recurring billing document. Because the flag was false at that point, the trigger raised:

"You cannot make this change because the document is linked to a contract"

...blocking all vendor billing document creation whenever such a localization was installed.

Root Cause

The sales-side procedure CreateSalesHeaderFromContract correctly sets "Recurring Billing" := true before calling Validate("Sell-to Customer No.", ...). The purchase-side procedure CreatePurchaseHeaderFromContract was missing the equivalent line before its vendor validation calls.

Fix

Add PurchaseHeader."Recurring Billing" := true; immediately after SetHideValidationDialog(true), mirroring the established pattern on the sales side:

Sales side (already correct):

SalesHeader.SetHideValidationDialog(true);
SalesHeader."Recurring Billing" := true;
SalesHeader.Validate("Sell-to Customer No.", ...);

Purchase side (after fix):

PurchaseHeader.SetHideValidationDialog(true);
PurchaseHeader."Recurring Billing" := true;
PurchaseHeader.Validate("Pay-to Vendor No.", ...);

Tests

Added CreateBillingDocumentsForVendorContractSetsRecurringBillingBeforeVendorValidation to RecurringBillingDocsTest (codeunit 139687). The test:

1. Creates a vendor contract with a separate Pay-to Vendor (the exact field whose validation triggers the error)
2. Creates a billing proposal and billing documents from that contract
3. Asserts PurchaseHeader."Recurring Billing" = true
4. Asserts PurchaseHeader."Pay-to Vendor No." matches the contract

[Copilot]

Pull request overview

Fixes vendor billing document creation for vendor contracts when localization extensions validate "Pay-to Vendor No." differently for recurring billing documents by ensuring the purchase header is marked as recurring billing before vendor field validation runs.

Changes:

• Set PurchaseHeader."Recurring Billing" := true immediately after SetHideValidationDialog(true) in CreatePurchaseHeaderFromContract, before validating vendor fields.
• Add a new test intended to cover the regression scenario for contracts with separate Pay-to Vendor.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Apps/W1/Subscription Billing/App/Billing/Codeunits/CreateBillingDocuments.Codeunit.al	Marks the purchase header as recurring billing before "Pay-to Vendor No." validation to avoid localization-triggered validation failures.
src/Apps/W1/Subscription Billing/Test/Billing/RecurringBillingDocsTest.Codeunit.al	Adds a regression test for the vendor contract scenario with differing Pay-to vs Buy-from vendor.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.