refactor: adopt idiomatic cobra patterns across all commands#279
Closed
mynk8 wants to merge 3 commits intomicrocks:masterfrom
Closed
refactor: adopt idiomatic cobra patterns across all commands#279mynk8 wants to merge 3 commits intomicrocks:masterfrom
mynk8 wants to merge 3 commits intomicrocks:masterfrom
Conversation
Replace Run with RunE, manual len(args) checks with cobra.Args validators, and os.Exit(1) calls with error returns across all 11 command files. The original cobra migration (PR microcks#125) directly translated the old flag/command.Execute() pattern into cobra's Run, preserving os.Exit(1) for error handling. This meant cobra's PreRunE, Args, and RunE hooks were never adopted, and deferred calls were skipped on errors. Changes: - All commands: Run -> RunE returning error - test: Args ExactArgs(3), PreRunE for runner validation - import: Args MinimumNArgs(1) - import-url: Args MinimumNArgs(1) - import-dir: Args ExactArgs(1) - login: Args ExactArgs(1), PreRunE for --sso-port range validation - logout: Args ExactArgs(1) - context: conditional arg validation in RunE - start: PreRunE for --port range validation - Root command: add SilenceErrors alongside existing SilenceUsage - 24 os.Exit(1) calls removed, replaced by error returns - log.Fatalf calls in start/stop replaced by fmt.Errorf returns - Port validation tests for --port and --sso-port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.