fix: use json.Marshal in CreateResult instead of string concatenation#274
Open
rubrx wants to merge 1 commit intomicrocks:masterfrom
Open
fix: use json.Marshal in CreateResult instead of string concatenation#274rubrx wants to merge 1 commit intomicrocks:masterfrom
rubrx wants to merge 1 commit intomicrocks:masterfrom
Conversation
|
👋 @rubrx Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
Signed-off-by: Krie <112789870+R-Kri@users.noreply.github.com>
rubrx
force-pushed
the
fix/create-test-result-json-marshal
branch
from
412502e to
27738af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateTestResult was building JSON with string concatenation, which could break or allow injection if inputs had quotes/backslashes.
Switched to a typed struct + json.Marshal for safe escaping, and properly unmarshaled filteredOperations, operationsHeaders, and oAuth2Context before combining...
Tests:
fixes #266