fix: avoid nil interface panic on Keycloak config discovery#272
Open
pulkitvats2007-crypto wants to merge 1 commit intomicrocks:masterfrom
Open
fix: avoid nil interface panic on Keycloak config discovery#272pulkitvats2007-crypto wants to merge 1 commit intomicrocks:masterfrom
pulkitvats2007-crypto wants to merge 1 commit intomicrocks:masterfrom
Conversation
Signed-off-by: pulkitvats2007-crypto <pulkitvats2007@gmail.com>
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetKeycloakURL()when interacting with a Microcks server that has Keycloak disabled.auth-server-urlandrealmfields, which are absent when the/api/keycloak/configendpoint returns{ "enabled": false }. This caused a fatal panic:panic: interface conversion: interface {} is nil, not string.enabledflag and only access Keycloak-specific fields when it istrue."null"safely when Keycloak is disabled instead of crashing.Implementation Details
Testing & Prevention
pkg/connectors/microcks_client_test.gousinghttptest.Server."null"return.Impact
microcks loginmicrocks testRelated issue(s)
Fixes #267