Skip to content

fix: exit with clear error when --waitFor value is not a valid number #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbroudoux merged 1 commit into from
May 4, 2026
+21 −7
Merged

fix: exit with clear error when --waitFor value is not a valid number #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions cmd/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ func NewTestCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {

// Validate presence and values of flags.
if !strings.HasSuffix(waitFor, "milli") && !strings.HasSuffix(waitFor, "sec") && !strings.HasSuffix(waitFor, "min") {
fmt.Println("--waitFor format is wrong. Applying default 5sec")
fmt.Println("--waitFor format is wrong. Accepted units are: milli, sec, min (e.g. 500milli, 30sec, 5min)")
os.Exit(1)
}

// Collect optional HTTPS transport flags.
Expand All @@ -85,15 +86,28 @@ func NewTestCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
config.Verbose = globalClientOpts.Verbose

// Compute time to wait in milliseconds.
var waitForMilliseconds int64 = 5000
var waitForMilliseconds int64
if strings.HasSuffix(waitFor, "milli") {
waitForMilliseconds, _ = strconv.ParseInt(waitFor[:len(waitFor)-5], 0, 64)
n, err := strconv.ParseInt(waitFor[:len(waitFor)-5], 0, 64)
if err != nil {
fmt.Printf("--waitFor value %q is not a valid number\n", waitFor)
os.Exit(1)
}
waitForMilliseconds = n
} else if strings.HasSuffix(waitFor, "sec") {
waitForMilliseconds, _ = strconv.ParseInt(waitFor[:len(waitFor)-3], 0, 64)
waitForMilliseconds = waitForMilliseconds * 1000
n, err := strconv.ParseInt(waitFor[:len(waitFor)-3], 0, 64)
if err != nil {
fmt.Printf("--waitFor value %q is not a valid number\n", waitFor)
os.Exit(1)
}
waitForMilliseconds = n * 1000
} else if strings.HasSuffix(waitFor, "min") {
waitForMilliseconds, _ = strconv.ParseInt(waitFor[:len(waitFor)-3], 0, 64)
waitForMilliseconds = waitForMilliseconds * 60 * 1000
n, err := strconv.ParseInt(waitFor[:len(waitFor)-3], 0, 64)
if err != nil {
fmt.Printf("--waitFor value %q is not a valid number\n", waitFor)
os.Exit(1)
}
waitForMilliseconds = n * 60 * 1000
}

var mc connectors.MicrocksClient
Expand Down
Loading