fix: handle json.Unmarshal error in GetTestResult#258
Merged
lbroudoux merged 1 commit intomicrocks:masterfrom May 4, 2026
Merged
Conversation
mugiwaraluffy56
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
…oring it Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>
mugiwaraluffy56
force-pushed
the
fix/get-test-result-unmarshal-error
branch
from
50c1a8e to
68cc46a
Compare
lbroudoux
approved these changes
May 4, 2026
Member
lbroudoux
left a comment
lbroudoux
left a comment
There was a problem hiding this comment.
This is a nice catch! Thanks for taking the time to push this one.
lbroudoux
added
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetTestResultinmicrocks_client.gocalledjson.Unmarshalbut ignored the returned error. every other unmarshal call in the same file checks it, this one didn't.the problem is that if the api returns something unexpected (an html error page, a rate-limit response, or a not-yet-ready response during startup),
json.Unmarshalfails silently andresultstays as a zero-valueTestResultSummarywithSuccess=falseandInProgress=false. the polling loop incmd/test.goseesinProgress=false, exits immediately, and the user gets a failure with no useful message.the fix is straightforward: check the error and return it so the caller gets a real error instead of a silent bad result.
also removed the redundant
[]byte(body)cast sinceio.ReadAllalready returns[]byte.