Fix rolling builds#323
Open
Amronos wants to merge 2 commits intomicro-ROS:rollingfrom
Open
Conversation
Amronos
force-pushed
the
fix-rolling
branch
2 times, most recently
from
77f944b to
be6b0e5
Compare
This was referenced Feb 26, 2026
Amronos
force-pushed
the
fix-rolling
branch
2 times, most recently
from
b85c158 to
d2c43d8
Compare
Merged
Contributor
|
I have just merged the first PR. Rerunning the CI now |
A new package was added to `rcl_logging` called `rcl_logging_implementation`. It depends on `rcpputils`, which I wasn't able to get building. Therefore, we are skipping building that package using `COLCON_IGNORE`. https://github.com/ros2/rclc needs to be pinned to an older version until ros2/rcl#1269 is added in https://github.com/micro-ROS/rcl. https://github.com/ros2/rosidl needs to be pinned to an older version due to breaking changes made with ros2/rosidl#941
Member
Author
|
This PR is good to merge from my side. The current failures are related to embeddedRTPS, which I would say is out of the scope of this PR. After all current PRs are merged, I will make a PR to temporarily disable its builds in CI until we fix it/it gets updated to rolling. |
This was referenced Apr 29, 2026
Member
Author
|
@Narukara @EugenioCollado could you review/merge this PR |
Narukara
reviewed
Apr 29, 2026
Comment on lines
+87
to
+90
| touch src/rosidl/rosidl_typesupport_introspection_cpp/COLCON_IGNORE; \ | ||
| touch src/rcl_logging/rcl_logging_implementation/COLCON_IGNORE; \ | ||
| touch src/rcl_logging/rcl_logging_spdlog/COLCON_IGNORE; \ | ||
| touch src/rclc/rclc_examples/COLCON_IGNORE; \ |
Contributor
There was a problem hiding this comment.
should be single tab here?
Member
Author
There was a problem hiding this comment.
Could you push a commit to fix that? I don’t have my main workstation with me currently and am not able to figure it out with the GitHub ui.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new package was added to
rcl_loggingcalledrcl_logging_implementation. It depends onrcpputils, which I wasn't able to get building. Therefore, we are skipping building that package usingCOLCON_IGNORE.https://github.com/ros2/rclc needs to be pinned to an older version until ros2/rcl#1269 is added in https://github.com/micro-ROS/rcl.
https://github.com/ros2/rosidl needs to be pinned to an older version due to breaking changes made with ros2/rosidl#941.
This is part 2 of 4 in a stack made with GitButler:
Changes specific to this PR:
d2c43d8