test: cover qualified function calls with three segments#448
Open
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Open
test: cover qualified function calls with three segments#448hjotha wants to merge 2 commits intomendixlabs:mainfrom
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Conversation
Symptom: the qualified function call regression coverage only asserted a two-segment callee and left the bug-test coverage implicit. Root cause: the expression parser fix accepts qualifiedName callees, including three-segment names, but the tests did not pin that shape directly. Fix: update the visitor regression to use a synthetic three-segment callee and add a parser-level bug-test MDL file that checks the same IF-condition form. Tests: ran make build, targeted mdl/visitor qualified-call tests, mxcli check for the bug-test MDL file, make test, and make lint-go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #447.
Summary
Validation
make buildgo test ./mdl/visitor -run 'TestQualifiedCallInIfCondition|TestQualifiedCallPositionalArgs' -v./bin/mxcli check mdl-examples/bug-tests/qualified-function-call-expression.mdlmake testmake lint-go