test: cover empty EndEvent return serialization#446
Open
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Open
test: cover empty EndEvent return serialization#446hjotha wants to merge 2 commits intomendixlabs:mainfrom
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Conversation
Symptom: the regression test named as empty EndEvent coverage used the literal string "empty", so it did not prove how the writer serializes an actual empty ReturnValue. Root cause: the fixture value matched the textual MDL expression for empty instead of the zero-length BSON field value used by void EndEvents. Fix: set ReturnValue to the empty string and assert that the serialized BSON keeps the ReturnValue field as an empty string. Tests: ran make build, targeted sdk/mpr EndEvent tests, make test, and make lint-go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #445.
Summary
ReturnValue.$Resultcase.Validation
make buildgo test ./sdk/mpr -run 'TestSerializeEndEvent_EmptyReturnValueHasNoTrailingLineBreak|TestSerializeEndEvent_NonEmptyReturnValueHasNoSyntheticLineBreak' -vmake testmake lint-go