fix: preserve mapping result range cardinality#372
Open
hjotha wants to merge 5 commits intomendixlabs:mainfrom
Open
fix: preserve mapping result range cardinality#372hjotha wants to merge 5 commits intomendixlabs:mainfrom
hjotha wants to merge 5 commits intomendixlabs:mainfrom
Conversation
36 tasks
hjotha
pushed a commit
to hjotha/mxcli
that referenced
this pull request
Apr 27, 2026
Adds an MDL script under mdl-examples/bug-tests/ exercising an `import from mapping` action that uses the same ResultHandlingMapping BSON shape that mendixlabs#372 splits apart. Pure-MDL authoring cannot reproduce the divergent Force/Range flag split (no Studio Pro REST client setup), so the script is a positive control: `mx check` must continue to report 0 errors. The negative case (Force vs Range divergence) is covered by the parser/writer Go tests in sdk/mpr/parser_microflow_test.go. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Apr 28, 2026
Collaborator
|
Cant merge due to conflicts |
Symptom: REST and import-mapping result handling can change cardinality metadata during roundtrip when ForceSingleOccurrence and Range.SingleObject differ. Root cause: ResultHandlingMapping had only one SingleObject flag, so parsing collapsed ForceSingleOccurrence into result cardinality and writing forced both BSON fields to the same value. Fix: store ForceSingleOccurrence separately, parse Range.SingleObject and ObjectType as result-cardinality signals, and write ForceSingleOccurrence independently from Range.SingleObject for REST and XML import mappings. Tests: add parser/writer coverage for object-valued mapping results with ForceSingleOccurrence=false. make build, make lint-go, and make test pass.
Adds an MDL script under mdl-examples/bug-tests/ exercising an `import from mapping` action that uses the same ResultHandlingMapping BSON shape that mendixlabs#372 splits apart. Pure-MDL authoring cannot reproduce the divergent Force/Range flag split (no Studio Pro REST client setup), so the script is a positive control: `mx check` must continue to report 0 errors. The negative case (Force vs Range divergence) is covered by the parser/writer Go tests in sdk/mpr/parser_microflow_test.go. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hjotha
force-pushed
the
submit/rest-result-mapping-range-cardinality
branch
from
c1492c6 to
c799107
Compare
AI Code ReviewCritical Issues
Moderate Issues
Minor Issues
What Looks Good
RecommendationApprove. The fix correctly resolves the cardinality conflation bug with adequate test coverage. Minor concerns about XML parser asymmetry are mitigated by existing test coverage and backward compatibility needs. The bug-test script serves its purpose as a validity check despite directory naming. No blocker issues identified. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
Symptom: REST calls that returned import mappings could rename an explicit assignment such as $Items to the mapped entity name during exec, leaving later statements that still referenced $Items invalid. Root cause: the REST mapping builder always overwrote OutputVariable with the result entity short name, even when the MDL assignment already supplied a variable. Fix: only derive the entity-name fallback when the statement has no explicit output variable. Tests: add a synthetic builder regression that asserts both the action output and ResultHandlingMapping.ResultVariable preserve the authored name.
…pping-range-cardinality # Conflicts: # sdk/mpr/parser_microflow_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForceSingleOccurrenceseparately from result cardinalityRange.SingleObjectand object variable type as object-valued mapping signalsCloses #369. Part of #332.
Validation
make buildmake lint-gomake test