draft: stage remaining microflow roundtrip audit fixes#346
Draft
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Draft
draft: stage remaining microflow roundtrip audit fixes#346hjotha wants to merge 2 commits intomendixlabs:mainfrom
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Conversation
b9e9852 to
8468e58
Compare
Symptom: the focused upstream PR set does not yet include every local roundtrip-validity fix found during long-running audits of large legacy Mendix projects. Root cause: several remaining fixes are intertwined across microflow control-flow reconstruction, handler routing, split/case preservation, validation, and writer/parser compatibility. They need further extraction before they are suitable for review as individual upstream PRs. Fix: stage the remaining all-fixes tree as one draft branch so the outstanding local work is visible upstream while smaller PRs continue to be split out from it. This draft is not intended to merge as-is. Tests: make build, make test, and make lint-go pass on the staged tree.
8468e58 to
efa3acf
Compare
This was referenced Apr 27, 2026
This was referenced Apr 27, 2026
Symptom: enum split roundtrips could reorder an explicit `(empty)` case after named cases, and an empty-body grouped case could move behind a terminal branch. Root cause: the staged enum split builder selected split-flow anchors from branch geometry. `(empty)` branches used bottom-origin geometry, and empty-body branch tails were emitted after body branches, so the describer could not recover the original authoring order. Fix: carry the authoring branch index onto empty-body tails, encode the first split flow of order-sensitive branches using the existing split-case order anchors, and sort enum split flows by that encoded order before grouping cases during describe. Tests: added synthetic enum split regressions for `(empty)` before named cases and grouped empty-body cases before terminal cases; ran make build, make test, make lint-go, and a targeted two-microflow audit with clean mxcli and Mendix mx check results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #332.
This is a draft staging PR for the remaining local microflow roundtrip validity work that has not yet been split into focused upstream PRs. It is not intended to be merged as-is.
Why this exists:
Current status:
Focused issues tracking the remaining staged work:
Validation run locally:
make buildmake testmake lint-goNotes: